[PostRector] Fix unused import not removed on empty generic class name exists#5012
Merged
samsonasik merged 4 commits intomainfrom Sep 13, 2023
Merged
[PostRector] Fix unused import not removed on empty generic class name exists#5012samsonasik merged 4 commits intomainfrom
samsonasik merged 4 commits intomainfrom
Conversation
samsonasik
changed the title
samsonasik
commented
Sep 13, 2023
|
|
||
| namespace Rector\NodeTypeResolver\Node; | ||
|
|
||
| use PHPStan\Analyser\Scope; |
Member
Author
There was a problem hiding this comment.
hm.., it seems cause it used as @see Scope removed
Member
Author
There was a problem hiding this comment.
I see, it because @see is exists inside PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTextNode:
PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTextNode #18819
text: 'Contains @see Scope'
Member
Author
There was a problem hiding this comment.
Fixed by make @see not part of text, but independent docblock ac93c3e
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Member
Author
|
@TomasVotruba I am merging it ;) |
Member
|
Looks good 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#8200